add isDrawnWithInversionCircle prop #575
Conversation
shehaban
changed the title
|
only a port property |
seveibar
left a comment
seveibar
left a comment
There was a problem hiding this comment.
Refactor to schStyle={{ inversionCircle: boolean }}
|
This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| export interface SchStyle { | ||
| defaultPassiveSize?: "xs" | "sm" | "md" | string | number | ||
| defaultCapacitorOrientation?: "vertical" | "none" | ||
| inversionCircle?: boolean |
There was a problem hiding this comment.
Variable naming inconsistency detected. The PR description mentions adding 'isDrawnWithInversionCircle' property, but the actual implementation uses 'inversionCircle'. Variable naming and API design is important - the property name should be consistent with what was described in the PR. Consider either updating the property name to match the description ('isDrawnWithInversionCircle') or updating the PR description to match the implementation ('inversionCircle'). Boolean properties often benefit from descriptive names that clearly indicate their purpose, so 'isDrawnWithInversionCircle' would be more self-documenting.
| inversionCircle?: boolean | |
| isDrawnWithInversionCircle?: boolean |
Spotted by Graphite Agent (based on custom rule: Custom rule)
Is this helpful? React 👍 or 👎 to let us know.
2 participants
This PR introduces a new optional property, isDrawnWithInversionCircle, and its corresponding Zod schema. This allows users to specify whether a net should be rendered with an inversion circle (often used in digital logic schematics to represent a NOT/inverted signal).